Recently I was running some of my code through JSLint when I came up with this error. The thing I think is funny about this error though is that it automatically assumes that all == should be ===.
Does that really make any sense? I could see a lot of instances that you would not want to compare type, and I am worried that this could actually cause problems.
The word "Expected" would imply that this should be done EVERY time.....That is what does not make sense to me.
myVar == null
check, yes, big changes. ;^) Crockford's argument is that it made the code's meaning more precise, and that's hard to argue.
IMO, blindly using ===
, without trying to understand how type conversion works doesn't make much sense.
The primary fear about the Equals operator ==
is that the comparison rules depending on the types compared can make the operator non-transitive, for example, if:
A == B AND
B == C
Doesn't really guarantees that:
A == C
For example:
'0' == 0; // true
0 == ''; // true
'0' == ''; // false
The Strict Equals operator ===
is not really necessary when you compare values of the same type, the most common example:
if (typeof foo == "function") {
//..
}
We compare the result of the typeof
operator, which is always a string, with a string literal...
Or when you know the type coercion rules, for example, check if something is null
or undefined
something:
if (foo == null) {
// foo is null or undefined
}
// Vs. the following non-sense version:
if (foo === null || typeof foo === "undefined") {
// foo is null or undefined
}
JSLint is inherently more defensive than the Javascript syntax allows for.
From the JSLint documentation:
The == and != operators do type coercion before comparing. This is bad because it causes ' \t\r\n' == 0 to be true. This can mask type errors. When comparing to any of the following values, use the === or !== operators (which do not do type coercion): 0 '' undefined null false true If you only care that a value is truthy or falsy, then use the short form. Instead of (foo != 0) just say (foo) and instead of (foo == 0) say (!foo) The === and !== operators are preferred.
==
operator. The ===
is a special case... JSLint tries to make it seem like using ==
would somehow be wrong... However, try this: var x = 4, y = new Number(4); if (x == y) {alert('Javascript depends on == just embrace it!');}
. Primitive types have corresponding classes that substitute for them (Number
, String
) and Javascript depends on the ==
operator to make comparing these natural.
Keep in mind that JSLint enforces one persons idea of what good JavaScript should be. You still have to use common sense when implementing the changes it suggests.
In general, comparing type and value will make your code safer (you will not run into the unexpected behavior when type conversion doesn't do what you think it should).
Triple-equal is different to double-equal because in addition to checking whether the two sides are the same value, triple-equal also checks that they are the same data type.
So ("4" == 4)
is true, whereas ("4" === 4)
is false.
Triple-equal also runs slightly quicker, because JavaScript doesn't have to waste time doing any type conversions prior to giving you the answer.
JSLint is deliberately aimed at making your JavaScript code as strict as possible, with the aim of reducing obscure bugs. It highlights this sort of thing to try to get you to code in a way that forces you to respect data types.
But the good thing about JSLint is that it is just a guide. As they say on the site, it will hurt your feelings, even if you're a very good JavaScript programmer. But you shouldn't feel obliged to follow its advice. If you've read what it has to say and you understand it, but you are sure your code isn't going to break, then there's no compulsion on you to change anything.
You can even tell JSLint to ignore categories of checks if you don't want to be bombarded with warnings that you're not going to do anything about.
A quote from http://javascript.crockford.com/code.html:
=== and !== Operators. It is almost always better to use the === and !== operators. The == and != operators do type coercion. In particular, do not use == to compare against falsy values.
JSLint is very strict, their 'webjslint.js' does not even pass their own validation.
webjslint.js
not validating--though most of the errors I see right now have to do with spacing. Clearly, one must use common sense and reasonable judgment when reviewing JavaScript using JSLint.
always
automatically disqualifies this quote as wisdom. Smart programmers aren't dogmatic. They use what is best in the given situation. And they welcome and embrace any tool built in to the very core of the language, not just dismiss it with a just never touch it
. Bottom line: My code is shorter (and not just from saving one =
character), thus my site loads faster, at less bandwidth cost, thus my user is better served.
If you want to test for falsyness. JSLint does not allow
if (foo == null)
but does allow
if (!foo)
===
, which JSLint recommends.
foo == null
checks for null or undefined. !foo
checks for null, undefined, 0 and empty string.
To help explain this question and also explain why NetBeans (from) 7.3 has started showing this warning this is an extract from the response on the NetBeans bug tracker when someone reported this as a bug:
It is good practice to use === rather than == in JavaScript.
The == and != operators do type coercion before comparing. This is bad because it causes ' \t\r\n' == 0 to be true. This can mask type errors. JSLint cannot reliably determine if == is being used correctly, so it is best to not use == and != at all and to always use the more reliable === and !== operators instead.
Well it can't really cause problems, it's just giving you advice. Take it or leave it. That said, I'm not sure how clever it is. There may well be contexts in which it doesn't present it as an issue.
Success story sharing
===
operator is code clarity. There is no reasonable situation to use==
as it will never be as clear and understandable as the identity operator. It's not about whether you understand the operators or not, it's about using the one which makes your code more easily readable at almost no expense. The only developers that are arguing against the identity operator are solo developers and people who don't work in teams. By definition, people who's code is not reviewed by enough eyes.there is no reasonable situation
is a gross misstatement. Think about (native) Javascript typesNumber
andString
. Their existence prove the Javascript authors had certain use cases in mind for==
. Do you really think thatnew String('hi') === 'hi'
evaluating tofalse
is very clear? Please write a code snippet that tests your function argument against'hi'
accepting both String and string and tell me that is clear.